Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace websockets with zmq #9173

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Replace websockets with zmq #9173

wants to merge 15 commits into from

Conversation

xjules
Copy link
Contributor

@xjules xjules commented Nov 11, 2024

Issue

POC: testing feasibility of zmq.

Approach
Implementing push-pull pattern for listening:

  • Server (ensemble evaluator) is doing the pull while each job_dispatch and is doing the push. It uses socket.send_multipart(sender, msg) to distinguish between the dispatcher and the client.

Implementing publish-subscribe pattern for informing:

  • In addition, all clients (Monitor) will act as subscribers to the server, which will use a single publish socket for informing them.

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@xjules xjules self-assigned this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant